Skip to content

[Fix] Changed endpoint names to follow RESTful API conventions #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kTrzcinskii merged 4 commits into from
Apr 19, 2025
Merged

[Fix] Changed endpoint names to follow RESTful API conventions #76

kTrzcinskii merged 4 commits into from
Apr 19, 2025

Conversation

@kubapoke
Copy link
Member

@kubapoke kubapoke commented Apr 18, 2025

As for several decisions made in this PR:

  • The controllers have been renamed, so that the API endpoints are plural. I have NOT renamed the services, as I believe that they should stay the way they are.
  • I have shortened the names of the endpoints to avoid unnecessary type repetitions or restating http request type in their names.

@kubapoke kubapoke requested a review from kTrzcinskii April 18, 2025 23:50
@kubapoke
Copy link
Member Author

kubapoke commented Apr 18, 2025

@kasrow12 @plebania you should probably take a look at this PR because the API endpoint paths have changed.

kTrzcinskii
kTrzcinskii approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@kTrzcinskii kTrzcinskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kTrzcinskii kTrzcinskii merged commit 4324066 into develop Apr 19, 2025
1 check passed
@kTrzcinskii kTrzcinskii deleted the fix/endpoint-names branch April 19, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kTrzcinskii kTrzcinskii kTrzcinskii approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kubapoke @kTrzcinskii